Implement new review method using MRs
Use new method introduced by Eric. Uses these commands:
git switch --orphan x.y.z
this creates an empty branch where x.y.z is the release candidate branch
But you can't normally push an empty branch, so then you have to use this to commit it:
git commit --allow-empty -m 'Initial commit'
Then push:
git push origin x.y.z
(if it was a forking workflow you'd actually use git push upstream x.y.z
)
Then create a merge request of main
into x.y.z
this will have all the changes and it's easy to comment on specific lines
Then, use whatever method you want to make the changes to main
as suggested by the reviewer (either branching or forking workflow)
Multiple people can approve the merge request so you can capture approval from all reviewers and your approving official.
If we move away from issue to merge request. We can just let people know they can be flexible in how they assign various aspects of the review (admin, technical, etc.) within the MR text.