From 60cf58eea9eed1204e96194085f0f42397a9fa51 Mon Sep 17 00:00:00 2001
From: Hal Simpson <hasimpson@usgs.gov>
Date: Fri, 8 Jul 2016 15:21:29 -0600
Subject: [PATCH] Changed how Popen is calling parameters,  to take care of the
 case of spaces in passwords and/or user names.

---
 geomagio/imfv283/GOESIMFV283Factory.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/geomagio/imfv283/GOESIMFV283Factory.py b/geomagio/imfv283/GOESIMFV283Factory.py
index 6185cdfa4..ef6245e72 100644
--- a/geomagio/imfv283/GOESIMFV283Factory.py
+++ b/geomagio/imfv283/GOESIMFV283Factory.py
@@ -40,7 +40,7 @@ class GOESIMFV283Factory(IMFV283Factory):
     Timeseriesfactory
     """
     def __init__(self, directory=None, getdcpmessages=None,
-            password = None, server=None, user=None, **kwargs):
+            password=None, server=None, user=None, **kwargs):
         IMFV283Factory.__init__(self, None, **kwargs)
         self.directory = directory
         self.getdcpmessages = getdcpmessages
@@ -127,10 +127,10 @@ class GOESIMFV283Factory(IMFV283Factory):
             print >> sys.stderr, server
             proc = subprocess.Popen(
                     [self.getdcpmessages,
-                    '-h ' + server,
-                    '-u ' + self.user,
-                    '-P ' + self.password,
-                    '-f ' + self.directory + '/' + self.criteria_file_name,
+                    '-h ', server,
+                    '-u ', self.user,
+                    '-P ', self.password,
+                    '-f ', self.directory + '/' + self.criteria_file_name,
                     '-t 60',
                     '-n'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
             (output, error) = proc.communicate()
-- 
GitLab