Use less generic variable names
The following discussion from !11 (merged) should be addressed:
-
@jmfee started a discussion: - use typed
Tuple
hints - maybe inline the param constants since they are only used once?
-
response1
andresponse2
are kind of generic -
buffer
is an existing type, use a different variable name.
def _download_debrisflow_data( webid: str, data_directory: str, gis_url: str = "https://earthquake.usgs.gov/arcgis/rest/services/ls/pwfdf_locations/MapServer/0/query" ) -> Tuple[Path, Path, str]: ... gis_query = requests.get(URLBASE, params).json() shapefile_url = ... shapefile_buffer = BytesIO(requests.get(shapefile_url).content) ...
- use typed