1.9.1 Domain Review

Domain reviews are specific to Scientific Software and ensure the software generates output that aligns with published or otherwise well-known expected results. Domain reviews may involve:

• Comparing output with external data sets
• Comparing algorithms with published, scholarly articles about the algorithm
• Reviewing unit and integration test results

Domain reviews should be performed by a trusted scientific expert with applicable subject-matter knowledge as well as sufficient applicable programming knowledge.

Domain reviews must be applied at Scientific Software stages:

• Approved Software

(1) Please document/show agreement/differences between the 2018 NSHM XML and 2018 NSHM JSON codes/models for PGA, 0.2, 1.0, and 5.0s SA and for Vs30 = 760 and 260 m/s (i.e., by producing difference and ratio maps for 2%, 5%, and 10% in 50-year PE).

(2) Please create a number of unit tests for sites across all NSHMs (CONUS, AK, HI, PRVI, GNMI, and AmSam).

changed title from Domain Review of nshmp-haz to 1.9.1 Domain Review

changed milestone to %NSHM Hazard Tool launch

added To Do label

See also nshmp-lib#114 (closed)

• PEER tests have been removed from nshmp-lib and relocated here (merge requests related to PEER). They now run automatically as part of this repository.
• End-to-end tests (that can be run on-demand) of the conus-2018 model have also been added (see !573 (merged)). Tests for other supported models, e.g. Hawaii, will be added soon.
• Documentation has been added describing different hazard code versions and showing the equivalence of results computed using nshmp-haz v1 and nshmp-haz v2 (that uses this library) for the spectral periods and return periods requested.

Reassigning to @ashumway for further comment or sign-off.

removed To Do label

added Needs Review label

assigned to @ashumway

Thank you for addressing and reconciling theses issues. I sign-off on the domain review for nshmp-haz.

closed

removed Needs Review label

mentioned in issue ghsc/nshmp/nshms/nshm-conus#18 (closed)