3.0.0 Domain Review

This issue documents the Domain Review for an "Approved Software" release of nshm-alaska, where tag 3.0.0 represents the 2023 Alaska NSHM. A domain review was not performed for the provisional release of nshm-alaska. For reference, the domain review for nshm-hawaii is here: nshm-hawaii#8 (closed)

Release candidate tag for review: 3.0.0rc-branch

Domain Review

Domain reviews are specific to Scientific Software (Refer to Scientific Software IM) and ensure the software generates output that aligns with published or otherwise well-known expected results. Domain reviews may involve:

• Comparing output with external data sets
• Comparing algorithms with published, scholarly articles about the algorithm
• Reviewing unit and integration test results

Domain reviews should be performed by a trusted scientific expert with applicable subject-matter knowledge as well as sufficient applicable programming knowledge.

USGS software review information: https://www.usgs.gov/products/software/software-management/types-software-review

added 2023 label

marked this issue as related to #25

marked this issue as related to #26

changed the description

End-to-end tests are here: https://code.usgs.gov/ghsc/nshmp/nshmp-haz/-/tree/main/src/test/resources/e2e/nshm-alaska-2023?ref_type=heads

changed the description

changed the description

assigned to @ashumway

End-to-end test sites for five sites across AK have been implemented (https://code.usgs.gov/ghsc/nshmp/nshmp-haz/-/tree/main/src/test/resources/e2e/nshm-alaska-2023?ref_type=heads). I have reviewed these test results and sign-off on the domain review for nshm-alaska.

marked the checklist item Comparing output with external data sets as completed

marked the checklist item Comparing algorithms with published, scholarly articles about the algorithm as completed

marked the checklist item Reviewing unit and integration test results as completed

changed milestone to %Finalize 2023 NSHM and ongoing GMM work

Domain review is complete and all comments have been reconciled as documented in this issue.

removed milestone %Finalize 2023 NSHM and ongoing GMM work

changed milestone to %New RTGM Calculator App, Disagg mods, PRVI