2.0.0 Administrative Security Review
This ticket documents the administrative security review performed against tag 2.0.0
of the nshm-hawaii
project.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Powers, Peter M. assigned to @bclayton
assigned to @bclayton
- Powers, Peter M. changed the description
changed the description
- Owner
Tag 2.0 and accompanying commits do not contain any personal, private, or sensitive information.
- Owner
CODE_OF_CONDUCT.md
Link to scientific code of conduct should not include
www
sub-domain Collapse replies - Author Owner
I think this is OK. The URL for the CoC seems to be jumping around a bit, but the CMA currently maps back in the
www
if you leave it out. Same comment for similarwww
items below.Edited by Powers, Peter M.
- Owner
DISCLAIMER.md
Disclaimer may need updated to include the
provisional
wording Collapse replies - Author Owner
Updated in !11 (merged)
- Owner
code.json
- URLS should reference the
raw
variation as opposed to theblob
version - URLs should point to resources matching version associated with the release
- The version associated with the release is defined in the
version
top-level key - It is understandably confusing that this tag may not yet exist, but we can still accurately predict these URLs values
- The version associated with the release is defined in the
-
version
not specified - Remove root
doi
section - Should
status
bedevelopment
? -
downloadURL
wrong URL, change to:https://code.usgs.gov/ghsc/nshmp/nshm-hawaii/-/archive/main/nshm-hawaii.zip
- Add
GeoJSON
andMarkdown
tolanguages
array? - What is the reason for the tag
doi|###TBD###
? Possibly remove. - Update
metadataLastUpdated
to proper date.
Side note: You may want to get an email that can be used for NSHMP development questions, something like
nshmp-dev-team@usgs.gov
- URLS should reference the
Collapse replies - Author Owner
Updated in !11 (merged). Version will be added to URLs upon completion of code review and change to
approved
release. We've secured the DOI that will be used.
- Owner
LICENSE.md
Link to USGS copyrights and credits should not include the
www
sub-domain - Owner
README.md
URLs should not include
www
sub-domain - Owner
I have completed the administrative security review as documented above. I've re-assigned this to @pmpowers for reconciliation.
- Clayton, Brandon Scott assigned to @pmpowers and unassigned @bclayton
- Powers, Peter M. mentioned in merge request !11 (merged)
mentioned in merge request !11 (merged)
- Powers, Peter M. mentioned in merge request !12 (closed)
mentioned in merge request !12 (closed)
- Author Owner
Issues identified in this review have been addressed in !11 (merged). This issue will be closed upon center director approval for provisional release.
- Powers, Peter M. mentioned in merge request !13 (merged)
mentioned in merge request !13 (merged)
- Powers, Peter M. changed milestone to %NSHM Hazard Tool launch
changed milestone to %NSHM Hazard Tool launch
- Clayton, Brandon Scott added To Do label
added To Do label
- Author Owner
Reassigning to @bclayton for further comment or sign-off.
- Powers, Peter M. removed To Do label
removed To Do label
- Powers, Peter M. added Needs Review label
added Needs Review label
- Powers, Peter M. assigned to @bclayton and unassigned @pmpowers