dataRetrieval merge requestshttps://code.usgs.gov/water/dataRetrieval/-/merge_requests2022-12-06T20:08:17Zhttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/434Pcode to name2022-12-06T20:08:17ZLaura A DeCiccoPcode to namehttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/433Typos2022-11-18T17:35:16ZHariharan, Jayaram AthreyaTypos- Fixes reference to `toxEval` package in installation instructions and deletes duplicate installation instructions later on the page.
- would -> will in contributing guide
- Makes example branch name consistent with screenshot- Fixes reference to `toxEval` package in installation instructions and deletes duplicate installation instructions later on the page.
- would -> will in contributing guide
- Makes example branch name consistent with screenshothttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/432How to contribute2022-11-22T18:43:14ZLaura A DeCiccoHow to contributeThis is in response to
https://github.com/DOI-USGS/dataRetrieval/issues/642This is in response to
https://github.com/DOI-USGS/dataRetrieval/issues/642https://code.usgs.gov/water/dataRetrieval/-/merge_requests/431Test ci2022-11-14T21:54:36ZLaura A DeCiccoTest cihttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/430Test ci2022-11-07T19:32:41ZLaura A DeCiccoTest cihttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/429Updated docs2022-10-19T20:45:19ZLaura A DeCiccoUpdated docshttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/428Catchup2022-10-17T19:31:09ZLaura A DeCiccoCatchuphttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/427Code Quality reporting2022-10-17T19:10:06ZHariharan, Jayaram AthreyaCode Quality reporting@ldecicco this adds the built-in code quality checker that ships with GitLab ([docs here](https://docs.gitlab.com/ee/ci/testing/code_quality.html)). I don't know exactly what criteria it is using to do the static code analysis (I don't t...@ldecicco this adds the built-in code quality checker that ships with GitLab ([docs here](https://docs.gitlab.com/ee/ci/testing/code_quality.html)). I don't know exactly what criteria it is using to do the static code analysis (I don't think it is specific to R) but it should [annotate the diff](https://docs.gitlab.com/ee/ci/testing/img/code_quality_mr_diff_report_v14_2.png) which is better than nothing.
If we wanted to run styler via a pipeline here, let me know and I could poke around at that. After a brief search I think it'd be a manual solution where we write the yaml markdown to call the appropriate R and shell commands to run the styler and then commit and push the changes via the pipeline. I'm not sure how we might run lintr beyond manually writing the R commands into the yaml and then reading the output, maybe we could have the output write to a text file or log that gets associated with the PR or commit.https://code.usgs.gov/water/dataRetrieval/-/merge_requests/426Main2022-02-18T18:39:34ZLaura A DeCiccoMainhttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/425Adding code.json2018-06-07T19:01:23ZLaura A DeCiccoAdding code.jsonhttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/420https2018-04-11T16:41:56ZLaura A DeCiccohttpshttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/416Bug in unique situation for RDB2018-02-09T18:04:58ZLaura A DeCiccoBug in unique situation for RDBhttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/413Gran release2018-01-03T21:52:40ZLaura A DeCiccoGran releasehttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/410different site for no data replace w/NA check2018-01-02T19:55:14ZDavid Watkinsdifferent site for no data replace w/NA checkhttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/412fix to NGWMN code and tests2018-01-03T18:56:10ZDavid Watkinsfix to NGWMN code and testshttps://code.usgs.gov/water/dataRetrieval/-/merge_requests/411Some comments start with quotes, but don't end with them...2018-01-02T20:47:40ZLaura A DeCiccoSome comments start with quotes, but don't end with them...Thanks Excel!Thanks Excel!https://code.usgs.gov/water/dataRetrieval/-/merge_requests/407fix ML2 parsing, NA removal in ML12017-11-30T21:58:50ZDavid Watkinsfix ML2 parsing, NA removal in ML1Apparently the NGWMN functions were hanging due to the parser, not the web service... now fixed. Still a bit confused about some of the behavior of `xml2::read_xml` when given a nodeset vs a node with children.
also fixes #392 Apparently the NGWMN functions were hanging due to the parser, not the web service... now fixed. Still a bit confused about some of the behavior of `xml2::read_xml` when given a nodeset vs a node with children.
also fixes #392 https://code.usgs.gov/water/dataRetrieval/-/merge_requests/400keep Xs for params that aren't changed2017-11-02T14:19:49ZDavid Watkinskeep Xs for params that aren't changedIf you don't supply the substitution for a column, the column name became all numbers.If you don't supply the substitution for a column, the column name became all numbers.https://code.usgs.gov/water/dataRetrieval/-/merge_requests/397Whoops! "Sys.Date()" not a constant...2017-09-28T15:02:12ZLaura A DeCiccoWhoops! "Sys.Date()" not a constant...https://code.usgs.gov/water/dataRetrieval/-/merge_requests/396Having the NGWMN data return even if the site request fails2017-09-28T13:43:33ZLaura A DeCiccoHaving the NGWMN data return even if the site request fails