waterdataui merge requestshttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests2022-07-01T20:41:28Zhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/371WDFN - 710 - Inverting the DV graph for certain parameter codes2022-07-01T20:41:28ZWilliams, Darius ShamarWDFN - 710 - Inverting the DV graph for certain parameter codesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Added a parameter code check in the DV graph to invert the y-axis for the same parameter codes that the IV graph does
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/365WDFN-735 Plot Secondary Parameter - fetch data and add data table2022-06-30T19:33:44ZBriggs, Aaron ShaneWDFN-735 Plot Secondary Parameter - fetch data and add data tableBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description WDFN-735 Plot Secondary Parameter - fetch data and add data table
-----------
This code fetches the second parameter selection data and adds it to the state. In addition, the it does the following:
- If a secondary time series is added to the graph, a table of data is shown in the 'Hydrograph data table(s)' accordion with data for that time series
- If the secondary time series is changed to a different parameter code, the Secondary parameter data table is updated to show the data for the newly selected parameter code.
- If the secondary parameter display is turned off after being on, it removes the secondary data table from the Hydrograph data table section.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialBriggs, Aaron ShaneBriggs, Aaron Shanehttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/364wdfn-746 - More generic sorting, nav arrows, bug fix2022-06-30T14:10:35ZWilliams, Darius Shamarwdfn-746 - More generic sorting, nav arrows, bug fixBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Adding navigation arrows, better element usage, directional sorting arrows, more generic sorting for input objects
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/361WDFN - 749/750 - Account for temperature parameter codes2022-06-29T16:04:41ZWilliams, Darius ShamarWDFN - 749/750 - Account for temperature parameter codesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Changed the places where a raw parameter code was compared with the period of record to use the temperature code stripped version
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/362WDFN-733 Plot 2nd Time Series - implement UI2022-06-29T16:04:04ZBriggs, Aaron ShaneWDFN-733 Plot 2nd Time Series - implement UIBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description WDFN-733 Plot 2nd Time Series - implement UI
-----------
Includes changes to the user interface such that the user can select from a list of secondary parameters. Changes include this that were listed in the acceptance criteria
- Checkbox added to each expandable section of the parameter selection table
- Un-clicking the checkbox will re-enable the compare and median checkboxes and remove the secondary parameter from the graph title.
- The initial implementation will show only the parameter name for the label for each secondary time series option
- Selecting a new row in the parameter table will retain the secondary time series and draw it on the graph with the newly selected series. If the new series is the same as the secondary series, it will uncheck the option to plot a secondary time series
These change where also listed in the acceptance criteria but could not be done in this ticket as the data required must first be fetched from the data source which is part of ticket https://internal.cida.usgs.gov/jira/browse/WDFN-735
- Clicking the check box will show the secondary parameter in the graph title below the primary parameter and disable the compare and median checkboxes.
- Only the ‘sampling method/sublocation’ normally graphed will be listed as an option
- If there are multiple sampling methods the method name should be added in brackets ‘[ ]’
- Changing the secondary parameter that is selected updates the title in the hydrograph.
Additionally, the test coverage for parameter-selection.vue is only 86% which was because some things were hard to test, but also some things are in progress and don't yet have an action attached to the change whose result can be tested.
One more thing, in the end I retained the current ability that allows the user to expand a non-selected parameter row. Because of this the user can select a second parameter to graph from any row. From a logic perspective this seems consistent with how the second parameter selection should work, which is that it is independent from the primary parameter selection. However, I have mixed feelings about this from the perspective of user experience and user expectation.
Image - Primary parameter, Gage height, selected and secondary parameter selected from the expanded but non-selected row of Discharge.
![image](/uploads/169e74610a454944b97deaaef8a660ff/image.png)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialBriggs, Aaron ShaneBriggs, Aaron Shanehttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/360Wdfn 674 - Make Vue paginated table with sorting ability2022-06-28T18:32:52ZWilliams, Darius ShamarWdfn 674 - Make Vue paginated table with sorting abilityBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Added a paginated table vue component and removed the List.JS library
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/355wdfn-757 --- hide latest value for multiple tables2022-06-27T13:41:03ZWilliams, Darius Shamarwdfn-757 --- hide latest value for multiple tablesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Hiding the latest value column if there is more than one statistics table.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/352WDFN-757 - Adding support for multiple stats tables2022-06-23T15:50:40ZWilliams, Darius ShamarWDFN-757 - Adding support for multiple stats tablesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Now the vue component loops through all available methods and makes tables for all of them.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/351Wdfn 744 replace select actions with vue2022-06-22T20:02:03ZBriggs, Aaron ShaneWdfn 744 replace select actions with vueBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description WDNF-744 Replace Select Actions with Vue
-----------
Consolidates the old select actions component with the new Vue TimeSpanControls and downloadData vue components
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialBriggs, Aaron ShaneBriggs, Aaron Shanehttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/350Wdfn 747 - Convert the statistics table component to vue2022-06-22T18:38:03ZWilliams, Darius ShamarWdfn 747 - Convert the statistics table component to vueBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Removed statistics-table.js and related tests and replaced it with a vue app.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/349Update dependencies2022-06-21T16:46:44ZBucknell, Mary S.Update dependenciesBefore making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Update all javascript and python dependencies
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialBucknell, Mary S.Bucknell, Mary S.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/348WDFN-743 Replace Time Span Controls with Vue2022-06-21T16:12:17ZBriggs, Aaron ShaneWDFN-743 Replace Time Span Controls with VueBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description WDFN-743 Replace Time Span Controls with Vue
-----------
Converts the Time Span Controls to Vue.
I ran into an issue with the initialization which needs futherwork and prevents some unit tests from being writing as needed.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialBriggs, Aaron ShaneBriggs, Aaron Shanehttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/347warp-745 - Cleanup and missing test2022-06-17T15:39:51ZWilliams, Darius Shamarwarp-745 - Cleanup and missing testBefore making a pull request
----------------------------
- [x] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [x] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Test that I forgot to add to the previous merge request
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/345Wdfn 745 - Replace components/hydrograph/time-span-shortcuts.js with a Vue co...2022-06-17T14:31:28ZWilliams, Darius ShamarWdfn 745 - Replace components/hydrograph/time-span-shortcuts.js with a Vue componentBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Converted the time span shortcuts component and its related tests to use Vue.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/346fix data-label on statistics table header2022-06-16T20:31:00ZWilliams, Darius Shamarfix data-label on statistics table headerBefore making a pull request
----------------------------
- [x] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [x] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Removed a redundant index
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/343Use lowercase for vue import2022-06-15T15:35:01ZBucknell, Mary S.Use lowercase for vue importBefore making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Describe the changes made. Note anything that you want the reviewers to know while reviewing your pull request
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialBucknell, Mary S.Bucknell, Mary S.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/342Wdfn 740 - Replace components/hydrograph/parameters.js with a Vue component2022-06-15T13:33:46ZBucknell, Mary S.Wdfn 740 - Replace components/hydrograph/parameters.js with a Vue componentBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Replaced parameters.js in monitoring-location/components with a Vue component, parameter-selection.vue. Also replaced method-picker.js with a Vue component method-picker.vue. I was able to simplify the markup used to render each parameter code row by using the css style attribute "order" to control the order that components where rendered determined by media queries.
This also covers WDFN-741.
There are additional tickets that might come out of this, including making a separate Vue component for the info tooltip. At some point we should also investigate putting component specific style in the components. I may still do this as part of this ticket but for now I am satisified that this meets the acceptance criteria.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialBucknell, Mary S.Bucknell, Mary S.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/341Wdfn 742 replace download data js with vue2022-06-14T21:40:03ZBriggs, Aaron ShaneWdfn 742 replace download data js with vueBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description WDFN-742 Replace Download Data JS with Vue
-----------
Replaces downloadData component with Vue component and increases test coverage.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialBriggs, Aaron ShaneBriggs, Aaron Shanehttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/320Wdfn 736 - Adding statistical data to the ML pages2022-06-13T15:30:07ZWilliams, Darius ShamarWdfn 736 - Adding statistical data to the ML pagesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json, versionNumber and metadataLastUpdated.
Description
-----------
Added a data table below the parameter selection table
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialWilliams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/340I had to bump the initial zoom level down a notch in order to get a bounding...2022-06-10T13:44:05ZBucknell, Mary S.I had to bump the initial zoom level down a notch in order to get a bounding...I had to bump the initial zoom level down a notch in order to get a bounding box with differences at the tenths.I had to bump the initial zoom level down a notch in order to get a bounding box with differences at the tenths.Bucknell, Mary S.Bucknell, Mary S.