waterdataui merge requestshttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests2021-09-01T21:13:59Zhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/67WDFN-637: Meta data tags for og:image and twitter:image do not include the pa...2021-09-01T21:13:59ZBucknell, Mary S.WDFN-637: Meta data tags for og:image and twitter:image do not include the parameter codeBefore making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Use the graph server endpoint in the config fi...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Use the graph server endpoint in the config file and use the default_parameter_code to set the parameter code.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/65Update changelog in prep for release2021-08-31T19:17:41ZBucknell, Mary S.Update changelog in prep for releasehttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/63Wdfn 608 rename flood stage to minor flood stage2021-08-31T13:58:21ZBriggs, Aaron ShaneWdfn 608 rename flood stage to minor flood stageBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description -WDFN 608 Rename Flood Stage to Minor Flood Stage
--------...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description -WDFN 608 Rename Flood Stage to Minor Flood Stage
-----------
This was the a standard name change, so I bundled it with a couple other minor changes
- Fix for the issue where the noValueCode is a number which is compared to the value which is a string
- Adds additional validation to the phone number of the feedback for to match the format 555-555-5555
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/62WDFN-641 - Calendar picker icons for the Change Time Span are rendered twice2021-08-30T20:16:23ZBucknell, Mary S.WDFN-641 - Calendar picker icons for the Change Time Span are rendered twiceBefore making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Moved the loading of the javascript bundled to...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Moved the loading of the javascript bundled to the bottom of the body tag as recommended by USWDS and removed the async directive.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/61Add dash at end of query.2021-08-30T16:18:22ZBucknell, Mary S.Add dash at end of query.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/58Wdfn 614 decimals in gw table truncated2021-08-30T13:04:50ZBriggs, Aaron ShaneWdfn 614 decimals in gw table truncatedBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description -WDFN 614 Decimals in GW Table Truncated
-----------
This ...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description -WDFN 614 Decimals in GW Table Truncated
-----------
This was caused by a type conversion from String (as received from the services) to Float. When doing this conversion JavaScript drops trailing zeros as it as no way determining the significant digits of the number. Allowing JavaScript to compare the data as strings prevents the loss of the digits.
This issue was also present on the Instantaneous Values table, and that is fixed as well.
Now the number of trailing digits should reflect the data as it was when received from the services.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/57Updated javascript dependencies including wdfn-viz2021-08-27T16:40:30ZBucknell, Mary S.Updated javascript dependencies including wdfn-vizhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/56WDFN-338 - Monitoring location pages cursor slider for both graphs, updates a...2021-08-27T16:00:23ZBucknell, Mary S.WDFN-338 - Monitoring location pages cursor slider for both graphs, updates as the handle is moved.Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
In order to handle the onchange event correctl...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
In order to handle the onchange event correctly, we needed to decouple the setting of the cursor position from the creation of the slider. This meant that we could no longer have a common d3-rendering module to render the cursor slider as the the D3 slider function needed to be available to both the Redux event handler which creates the slider and the the event handler which updates the cursor value.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/55Wdfn 567 add validation to email address of user feedback2021-08-27T13:41:08ZBriggs, Aaron ShaneWdfn 567 add validation to email address of user feedbackBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description - WDFN 567 Add Validation to Email Address in Feedback For...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description - WDFN 567 Add Validation to Email Address in Feedback Form
-----------
This adds an additional pattern match to the standard HTML5 email address validation. The standard match allows the brower's creators to decide the type of validation provided. Some browsers will not check for a '.' since according to the email address standard, there can be addresses with no '.'. In practice these email addresses are very rare so can reasonably be excluded. So an additional regular expression pattern is used to create filter for most common addresses. This pattern will be enforced on all browsers.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/54Set autorefresh to true. I think this allows automatic reloading of assets so...2021-08-26T19:24:40ZBucknell, Mary S.Set autorefresh to true. I think this allows automatic reloading of assets so...Set autorefresh to true. I think this allows automatic reloading of assets so that that server doesn't have to be restarted each time assets change.Set autorefresh to true. I think this allows automatic reloading of assets so that that server doesn't have to be restarted each time assets change.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/53WDFN-551: Fixed circular dependency issue in list.js2021-08-26T17:47:38ZBucknell, Mary S.WDFN-551: Fixed circular dependency issue in list.jsBefore making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately - Change to dependencies. No changelog update is needed
Description
--...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately - Change to dependencies. No changelog update is needed
Description
-----------
Was able to fix the problem by pulling in the list.js dependency from the node_modules/src directory and pulled in the pagination dependency that was the problem before list.js itself. I also used the pagination options to adjust the pagination markup to have assign the href appropriately so that the scrolling to the top issue does not occur.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/52Wdfn 546 set current parameter to open view on page load2021-08-26T17:13:24ZBriggs, Aaron ShaneWdfn 546 set current parameter to open view on page loadBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description - WDFN-546 Set Current Parameter to Open on Page Load
----...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description - WDFN-546 Set Current Parameter to Open on Page Load
-----------
The row for the selected parameter is now expanded when the page loads, showing the Water Alert link and sampling methods/sublocations, if there is more than one.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/51Wdfn 556 click on page number scrolls to top2021-08-25T21:42:18ZBriggs, Aaron ShaneWdfn 556 click on page number scrolls to topBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description - WDFN-556 - Click on Hydrograph Data Table Pagination Num...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description - WDFN-556 - Click on Hydrograph Data Table Pagination Number Scrolls Page to Top
-----------
This is a issue in the List.js package and therefore isn't easy for us to fix. I did look through the List.js repository and didn't find any issues related to this problem.
The fix here works in 95% of the cases and stops the page moving to the top by locking the viewpoint of the page where it was when the pagination button was clicked. So for every page in the table, except the last one, this works perfectly. On the last page since the number of rows in the table is often much less than that of previous pages, it makes the page shorter. Since the viewpoint is fixed the page moves upward under the viewpoint sometimes causing the table to vanish from view.
So this is not a perfect solution, but it is much better than what it was. And the new behavior is something that could logically be expected.
With more work, it might be possible to tie the viewpoint to an element, such as the last row in the table, so that when the number of table rows changed, the viewpoint would move with it. I experimented with this a bit, and found some challenges, one, .focus(), when used on any of the table elements, even the anchor element in the pagination, would not change the viewpoint. Second since the page refreshes, we lose reference the element we would like to keep in view.
All in all, fixing this last pagination link seems like a challenge, and since we are considering moving to new tables (that are mobile friendly), the new implementation used may render this issue moot and so spending more time here may not be the best use of our resources.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/50Added font files to the gulpfile for hashing.2021-08-25T18:28:47ZBucknell, Mary S.Added font files to the gulpfile for hashing.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/49WDFN-626 - Remove Font Awesome dependency and use USWDS icons2021-08-25T17:19:18ZBucknell, Mary S.WDFN-626 - Remove Font Awesome dependency and use USWDS iconsBefore making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Removed the dependency on font-awesome and rep...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Removed the dependency on font-awesome and replaced by using USWDS sprite icons. Also added preload statements for the USWDS fonts to help improve page initial load performance.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/47Wdfn 622 issues with alaskan hucs2021-08-24T18:07:42ZBriggs, Aaron ShaneWdfn 622 issues with alaskan hucsBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description
-----------
Tests if the hydrologic unit code (HUC) is in ...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description
-----------
Tests if the hydrologic unit code (HUC) is in the official list of HUCs. If not, it will not show a link in the Metadata Table.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/44Wdfn 627 eliminate unneeded polyfills2021-08-23T15:04:20ZBriggs, Aaron ShaneWdfn 627 eliminate unneeded polyfillsBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description
-----------
Since Internet Explorer (IE) no longer accesse...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description
-----------
Since Internet Explorer (IE) no longer accesses the browser-side JavaScript code, the polyfills required to make certain features functional in IE are no longer needed. In this task, I first searched the code for any usage of functions for which we had previously included polyfills. I then removed the polyfills that no longer had any related functions. Then I went through the remaining polyfills and checked on https://caniuse.com/ to see if the related functions were now supported by the browsers in our use set (details are in a PDF in the Jira task). If the related functions had browser support, I removed the associated polyfill. In the end, no polyfills were needed. I then attempted to test the polyfill-less code in as many browsers as possible, these included Ubuntu Chrome, Firefox, Chromium, I attempted to use Browserstack to test further, with mixed results. None of the Mac or iOS systems would connect to the application (this was with and without the polyfills) so those remain untested. Most of the systems that did connect worked as expected. The ones that didn't, such as Safari for Windows, had issues with and without the polyfill, so I'm not sure if what I was seeing was a reflection of reality or an issue with Browserstack. In summary, I feel fairly confident based on the tests and the reports in https://caniuse.com/, but not 100% that all the polyfills will not be missed.
Update --
After Mary reminded me, I checked on the timezone support package. According to the package's web page, https://www.npmjs.com/package/date-time-format-timezone, we should use this table to check compatibility: http://kangax.github.io/compat-table/esintl/ . That table indicates that all but one rather obscure browser supports all the methods that this package targeted. So. I removed that too.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/41Use Whitenoise when enabled to serve static2021-08-20T14:59:49ZBucknell, Mary S.Use Whitenoise when enabled to serve staticBefore making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately - no update needed as change is to how we run locally
Description
----...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately - no update needed as change is to how we run locally
Description
-----------
Removed the local static server in favor of using WhiteNoise to serve the static from the web server. I also fixed some of the views test which were not mocking all of the service requests
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/43Wdfn 6342021-08-19T21:41:05ZBucknell, Mary S.Wdfn 634Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Added check for empty IV period of record befo...Before making a pull request
----------------------------
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
Description
-----------
Added check for empty IV period of record before determining if flood stages should be fetched.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivialhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/42Wdfn 632 switching methods does not update hydrograph or url2021-08-19T13:30:57ZBriggs, Aaron ShaneWdfn 632 switching methods does not update hydrograph or urlBefore making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description
-----------
I moved the 'onchange' event from the the opti...Before making a pull request
----------------------------
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
Description
-----------
I moved the 'onchange' event from the the options which do not really change to the select element that does change. This let's the application respond changes in the sampling method selection dropdown.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial