waterdataui merge requestshttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests2023-02-17T13:43:53Zhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/768Search and Filter - Update App and App Test2023-02-17T13:43:53ZSimpson, Robert (Contractor) EvanSearch and Filter - Update App and App TestBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Updates based on findings that @mbucknell uncovered with issue where the
SearchMap component was being tested when App test ran. This is handled
by setting `shallow` to true. Then the next issue came about where the
`mapBound` was null during the test run. To handle this, nullish
coallescing is being used so the value will be `0` when the `mapBounds`
is null. I went with this approach so `leaflet` would not have to be
imported only for this situation.
**Not associated with any JIRA tickets**
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/764Search and Filter - Add More Search Filters Component Tests2023-02-16T17:48:23ZSimpson, Robert (Contractor) EvanSearch and Filter - Add More Search Filters Component TestsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
**Not related to a JIRA tickets**
Adding some tests to handle coverage that was missing for the
`SearchFilters.test.js`.
Assigning to @mbucknell because I don't know if this is considered trivial or needs to be reviewed.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/745WASP-456 - Remove Apollo GraphQL from Search and Filter2023-02-16T14:56:55ZSimpson, Robert (Contractor) EvanWASP-456 - Remove Apollo GraphQL from Search and FilterBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Apollo and GraphQL have been removed in favor of using the `fetch` api.
With that, a new `search-graphql.js` in the `web-services` directory.
That handles the `fetch` call that is then called from the
`fetchLocations` action in the `search-and-filter-store.js`.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/765WDFN-967 - Fixed display issues on Safari with the time series graphs2023-02-16T14:30:57ZBucknell, Mary S.WDFN-967 - Fixed display issues on Safari with the time series graphsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
After investigating the problem and comparing with the code on production which was still working on Safari, I determined that the issue appeared to have been introduced when we changed the way we were centering the loading indicator, watermark, and no data overlay. The issue affected all time series graphs (the DV statistics graph and the multi site hydrograph).
I removed the use of flex for the container of the SVG. This eliminated the need to set the height of this div as well. Instead used flex within the overlay containers to center vertically and then set margin:auto to center the horizontal on the container within the outer container. There were a few other tweaks that had to be made.
I checked all use of the TimeSeriesGraph component and the LoadingIndicator component as styling changes and markup changes needed to be made to those components all usages on all pages appear to work as expected now on Chrome and Safari browsers and on different browser widths. Also checked to make sure the footer was not covering any page content on pages with time series graphs.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/762WASP-335: Search and Filter - Re-introduce map events and popover change2023-02-16T14:08:55ZSimpson, Robert (Contractor) EvanWASP-335: Search and Filter - Re-introduce map events and popover changeBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
The events that are needed for making a call to the service are brought
back in so it is explicit that the call should only happen for these
events. For `moveend`, it caused an issue where the popover that is
partially outside the bounds of the map will redraw the map and make a
call to the service. This is now fixed.
The location name is now shown in the popover as expected in the
acceptance criteria.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/763WASP-349: Seach and Filter - Markers and Clusters Fix2023-02-15T14:03:39ZSimpson, Robert (Contractor) EvanWASP-349: Seach and Filter - Markers and Clusters FixBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
The markers are now being added to the map correctly with the geoJSON
being returned and then being added to the marker cluster.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/749WASP-331: Seach and Filter - Implement Age of Data Filter2023-02-15T14:02:11ZSimpson, Robert (Contractor) EvanWASP-331: Seach and Filter - Implement Age of Data FilterBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
The Age of Data filter is passed as a variable to GraphQL request based
upon the selection from the filters. The selection is a number that is
subtracted from the current year to give the year that determines the
locations to return.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/755Search and Filter: Incremental Updates to Tests2023-02-14T21:30:59ZSimpson, Robert (Contractor) EvanSearch and Filter: Incremental Updates to TestsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Small refactoring for each of the tests.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/761WDFN-956 - Change IV data source to sensor things API2023-02-14T18:44:36ZBucknell, Mary S.WDFN-956 - Change IV data source to sensor things APIBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Rather than fetch the data from the waterservices IV service, use sensor things API.
I opted to fetch each site individually to simplify what is already a fairly complicated query. Each site fetch is requested in parallel. I needed to handle that sensor things only returns 1000 observations at a time, so if there are more observations for a given site/parameterCode/isoDuration, the @iot.nextLink is used to fetch the remainder and the observations are appended to the original requests observations.
Another difference in the API handling is that sites that do not have data for the parameterCode return a 404, so no site meta data will be received for these sites.
The shape of the multi-site-store changed to mirror the data. Please note that we are not handling site/parameterCode combinations that have more than one Datastream (or methods in NWIS vocabulary). We will need to address this issue in a subsequent JIRA.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/756wdfn-939 - passing the css even for error code pages2023-02-14T16:08:00ZWilliams, Darius Shamarwdfn-939 - passing the css even for error code pagesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Added the css to the context dictionary for HTML error pages on monitoring location sites.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/758WASP-349: Search and Filter - Map Clustering2023-02-14T15:14:54ZSimpson, Robert (Contractor) EvanWASP-349: Search and Filter - Map ClusteringBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Implement marker clustering to the map. Starting to understand how to build out the map which is helping to split out smaller functionality.
### Cluster
![Screenshot_from_2023-02-13_11-57-46](/uploads/5c4fb499bce87e2591102343ada5529c/Screenshot_from_2023-02-13_11-57-46.png)
### No clusters
At zoom levels below 11, there should be no clustering. This will have to be looked at to see how location markers are still overtop of each other and how to handle that situation.
![Screenshot_from_2023-02-13_13-58-13](/uploads/7f12aaf02d2437e635954311f09386e7/Screenshot_from_2023-02-13_13-58-13.png)
I believe this future story is geared towards handling this type of situation - https://internal.cida.usgs.gov/jira/browse/WASP-412
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/757WASP-335: Search and Filter - Map Marker Popover2023-02-14T14:34:28ZSimpson, Robert (Contractor) EvanWASP-335: Search and Filter - Map Marker PopoverBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Each marker that displays on the map has a popover that gives more
information about the location and a button that will take the user to
the monitoring location page in a new browser tab.
![Screenshot_from_2023-02-13_10-17-53](/uploads/ef938b3059ea5f58d3f4885691c0f2bf/Screenshot_from_2023-02-13_10-17-53.png)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/759dependency update2023-02-13T21:07:50ZWilliams, Darius Shamardependency updateBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Describe the changes made. Note anything that you want the reviewers to know while reviewing your pull request
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/760Exempt: Trivial - WDFN-903 multi site graph overlapping elements2023-02-13T20:56:17ZBriggs, Aaron ShaneExempt: Trivial - WDFN-903 multi site graph overlapping elementsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
WDFN-903 multi site graph overlapping elements
-----------
I moved the code that sizes the container for the multi-site graph and title into into the TimeSeriesGraph component. This fixes the multi-site graph and may fix the Safari zero-height issue.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/748Wdfn 926 - Prevent duplicitive y-axis values2023-02-10T21:33:10ZWilliams, Darius ShamarWdfn 926 - Prevent duplicitive y-axis valuesBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Increased the precision of y-tick marks to 3 decimal places if the range of data values cannot create unique labels to two decimal places. Added a magnitude check for creating log plots.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/750WDFN-957 Questions or Comments tab sticking to paginated table2023-02-10T21:25:46ZBriggs, Aaron ShaneWDFN-957 Questions or Comments tab sticking to paginated tableBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
WDFN-957 Questions or Comments tab sticking to paginated table
-----------
On mobile screens, the time column text was overflowing the paginated table. This overflow was cascading upward and confusing the 'sticky' property of the Question or Comments tab which was then stinking the wrong page elements.
Since there are multiple usability issues with this table on mobile devices, I looked for a stop-gap measure that would just get things running again. So I added a containing div within the DataTables.vue component and confined the any x-overflow to a scroll condition. This allows the 'sticky' property of the Questions comments tab to function as expected.
Note -- I don't have a method of testing the 'zero-height-hydrograph' as seen on Safari and thought to be related to this issue. So, if that turns out to still be a problem, we will have to address that in a different ticket.
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/751Exempt: Trivial - Wdfn 919 update ask usgs number2023-02-10T20:14:53ZBriggs, Aaron ShaneExempt: Trivial - Wdfn 919 update ask usgs numberBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [ ] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [ ] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Wdfn 919 update ask usgs number
-----------
Updates the USGS number
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/746wdfn-935f - add missing classes to temp-mlp2023-02-09T21:10:26ZWilliams, Darius Shamarwdfn-935f - add missing classes to temp-mlpBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [ ] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [ ] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Adding missing classes to style text on the temporary-mlp
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/741WASP-350: Search and Filter Map and Legend Integration2023-02-08T21:32:07ZSimpson, Robert (Contractor) EvanWASP-350: Search and Filter Map and Legend IntegrationBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
This is a follow up merge request based off of https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/726 which was closed because of the amount of comments making it hard to see the changes taking place.
This introduced the integration of the Location Type(s) filters with the API data that updates the markers on the map. Once the filters are selected, the legend below the map will update to show the location types being filtered.
Note that there is still work needed to get full coverage on the GraphQL implementation. One option could be moving away from `onResult` and `onError` in favor of exposing `result`, `loading`, and `error` returned from `useQuery`. Other options include moving this functionality into a composable that can be tested in isolation, or moving away from handling this in the store and using one of the components available as a wrapper from Vue Apollo. Right now the coverage can be seen below for the store showing where the coverage is missing.
I tried to use the recommendation from vitest for graphql using mock service worker - https://mswjs.io/ - and did not see it working correctly. That does not mean it will not work, but I would need more time to allocate for that integration.
![Screenshot_from_2023-02-07_14-34-24](/uploads/774c0a7dd9adc6530253030c9adf0814/Screenshot_from_2023-02-07_14-34-24.png)
With this new merge request, it is the hope that reviewing will be easier without the noise of the comments found in 726.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/742wdfn-935 - Create a separate app for hydrograph data selection2023-02-08T19:31:45ZWilliams, Darius Shamarwdfn-935 - Create a separate app for hydrograph data selectionBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Added a new vue app for hydrograph data selection and modified the monitoring location template to account for it.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamar