waterdataui merge requestshttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests2023-02-08T18:22:27Zhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/744Using media queries to hide the in-page navigation at widths that currently...2023-02-08T18:22:27ZBucknell, Mary S.Using media queries to hide the in-page navigation at widths that currently...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
We will now hide the in-page navigation at widths up to 880px to prevent the in-page navigation from falling off the page. It does this because the tables in the main section are wide enough that they prevent the main section from shrinking any further. The camera section is also showing this problem.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/743Added back in the hydrograph-wrapper id2023-02-08T14:05:14ZBucknell, Mary S.Added back in the hydrograph-wrapper idBefore making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
During the hydrograph controls consolidation cleanup, I removed the id hydrograph-wrapper which is needed by the graph server. This adds it back in.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/740WDFN-928 Use Eslint Plugin Import2023-02-07T19:54:36ZBriggs, Aaron ShaneWDFN-928 Use Eslint Plugin ImportBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
WDFN-928 Use Eslint Plugin Import
-----------
This adds the Eslint Plugin Import and associated eslint-import-resolver-custom-alias which resolves aliased imports.
I was not able to use the 'recommended' configuration for the Eslint Plugin Import because of errors that cropped up in several default settings.
Added from 'recommended' config
- export
- no-duplicates
- named
Part of 'recommended' config that won't work because of error: Parse errors in imported module 'vitest-fetch-mock': Cannot use keyword 'await' outside an async function (7:32)
- no-named-as-default
- no-named-as-default-member
- namespace
Part of 'recommended' that won't work because of unable to find a way to resolve the imports for @wma/wdfn-vue-components and vite/modulepreload-polyfill
- no-unresolved
Not part of 'recommended' but is what does what we want for this ticket
-order
I added custom setting such that the order of imports is pretty close to what we wanted
Features
- spaces between import groups
- group are ordered - "builtin", "external", "internal","parent", "sibling", "index", "object", "type"
- custom rules added for files specific to waterdataui
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/739WDFN-941 - Adjusted the markup to use the main tag appropriately and moved th...2023-02-06T22:33:15ZBucknell, Mary S.WDFN-941 - Adjusted the markup to use the main tag appropriately and moved the in-page navigation to fill the right side of the available screen.Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
The changes required changing the base.html template to remove the enclosing main tag. Instead in each template that inherits from base.html in the "content" block, the main tag should be used as appropriate. For in page navigation, it needs to be used for the page content part and should not include the in-page navigation. Also made some styling adjustments to use grid-container when appropriate as it should only be used when we want to limit the width of the div on desktop to 1024px and to allow the in-page navigation to take up more space.
![Screen_Shot_2023-02-06_at_9.06.04_AM](/uploads/7e6757b5fa5d406dc03e076f147728c4/Screen_Shot_2023-02-06_at_9.06.04_AM.png)
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/736WDFN-902 Add Date Filter to Hydrograph Table2023-02-03T20:11:09ZBriggs, Aaron ShaneWDFN-902 Add Date Filter to Hydrograph TableBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
WDFN-902 Add Date Filter to Hydrograph Table
-----------
This takes the text input filter Mary created for the 'Summary of all Field . . ." table and converts it to a reusable component which was then added to filter the data column of the hydrograph data tables.
Of note - the ticket asks that one filter filters all the tables shown. This turned out to be quite complicated due to the nature of the Vue watchers and the nested structure of the 'hydrographData' in the state. There most likely is a way around this issue, but since we don't know users will prefer as single filter for all tables or a filter for each table, I implemented a filter for each table, which was achievable without complication.
Image - Hydrograph data tables with new filters
![image](/uploads/4172af1aa62eaae2b67936e78a8f44b8/image.png)
Image - message when no data matches filter
![image](/uploads/5d2bf09472a6c7682bd4f85143f8196d/image.png)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/735WDFN-955 - Cleanup of the work to add the consolidated hydrograph controls2023-02-02T21:48:26ZBucknell, Mary S.WDFN-955 - Cleanup of the work to add the consolidated hydrograph controlsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Removed the compare/median graph controls, the select actions bar, and the statistics table section. Move the provisional tag directly below the statistics grid and above the slider controls button section. Removed the DATA_DETAILS_ENABLE feature flag.
In addition to this, I did a pass through the HydrographApp components to see if any of the markup could be simplified like removal of divs that were not required. I also checked to see if the appropriate aria attributes are being used on the custom control components that we have created. In addition, I updated the StatisticsGrid component to use the availableIvDataStore and the selected parameter codes. This store now includes what methods are available for each available IV parameter code and can be used rather than the fetched hydrograph data to determine whether a selected parameter code has multiple methods. This greatly simplifies the code and testing of the code. There are likely other opportunities for this kind of change. I am planning on opening a ticket whose goal is to remove any remaining dependencies on hydroggraphParameters and any other places where we are using the retrieved hydrographData to determine whether a parameter code has multiple methods.
I also did some test cleanup as as things moved around, in appropriate tests were left in inadvertently. I suspect I did not catch everything.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/727Wdfn 932 - Make DataDetailsRowControl accessible2023-02-01T20:01:27ZWilliams, Darius ShamarWdfn 932 - Make DataDetailsRowControl accessibleBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Added aria labels for the various possible add data line svg's.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/731pylint rules tightened up so had to make some linting adjustments.2023-02-01T16:12:30ZBucknell, Mary S.pylint rules tightened up so had to make some linting adjustments.Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Updates required by linting requirements.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/728WDFN 895 Move Subscribe to WaterAlert2023-02-01T16:07:09ZBriggs, Aaron ShaneWDFN 895 Move Subscribe to WaterAlertBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description WDFN 895 Move Subscribe to WaterAlert
-----------
This sets up the subscribe for WaterAlert section in the new toggle buttons.
Of note -
- the link to WaterAlert is not specific for a data type (this seems reasonable since the selections are separate from the graph, but it could also be argued that these links should work like the old version in the data types selection table). The upside of this is the code is simpler and there is no need to deal with the calculated parameter. The downside is the user will need to read through the data types list in WaterAlert
- There is not any filtering added for locations that may have no IV data and therefore no WaterAlert. To implement this, we would need to think through the various fringe cases and add a sensible message to the user as to why WaterAlert is not available. This could get complicated.
Image - new Subscribe section - desktop
![image](/uploads/11256017133c8fd4b2f61b04ab108dae/image.png)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/723Wdfn 934 - Hide tooltip text based on data details view visibility2023-01-31T21:43:40ZWilliams, Darius ShamarWdfn 934 - Hide tooltip text based on data details view visibilityBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Added events and injhections to find the current visibility of the data details view. Note that the tooltip text will not update on screen size change as currently implemented.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/724WDFN-893 Move view data options2023-01-31T19:09:38ZBriggs, Aaron ShaneWDFN-893 Move view data optionsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
WDFN-893 Move view data options
-----------
This makes a copy of the data tables and the 'retrieve data' options in the new buttons container
I made a new component called 'DataTables.vue' to facilitate the movement. This allowed the entire data tables section to moved as a unit to the new location.
In the process of making these changes I noticed an issued with the paginated table conflicting with the 'sticky' comments feedback tab on mobile. After investigating, I am sure that this issue has nothing to do with the changes here and is a pre existing issue with the paginated table. If remove all of the new code changes and then move the paginated table out of the accordion where it is currently located, I see the issue. I'm not sure what magic the current accordion provides that allows the Questions or Comments tab to work, but the paginated table should be useable outside of the accordion.
Image - new View data section desktop
![image](/uploads/d17f6c63495b8bdc8fbfdb2441764f69/image.png)
Image - new View data section mobile
![image](/uploads/f0600e39f50d1c479074a8c7e3cf41a9/image.png)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/717WASP-421: GraphQL and Apollo Integration for Search and Filter2023-01-31T14:51:46ZSimpson, Robert (Contractor) EvanWASP-421: GraphQL and Apollo Integration for Search and FilterBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Same code as https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/716 that had to be removed because of issues with the package file.
**NOTE** - I have left some comments in regards to decisions that can be made on how to handle parts of the GraphQL integration.
- Introduces Vue Apollo to handle interacting with GraphQL server.
- Adds a Pinia store to handle state and actions associated with data fetching and retrieval from GraphQL.
There are various moving parts and decisions still being made to how the map operates with the amount of data being sent back. The map can get overwhelmed visually and slow down performance when there are lots of markers being added.
I had a code review session with Aaron to give a high level overview of what is going on and where we are at right now. There are stories coming up that will handle more of the interactions that will overtake the static display of the filters and way the map functions based on those filters being set.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/722WDFN-894 move change time span2023-01-30T16:39:39ZBriggs, Aaron ShaneWDFN-894 move change time spanBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
WDFN-894 move change time span
-----------
This creates a copy of the time span controls inside of the new button container.
Image - time span controls desktop
![image](/uploads/fb7c6492886929b00ee57479dd11619b/image.png)
Image - time span controls mobile
![image](/uploads/07af4adf20ec3c93f4bfb5b6caba1fc7/image.png)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/718WDFN-891 Investigate Side Scroll Buttons2023-01-30T15:37:46ZBriggs, Aaron ShaneWDFN-891 Investigate Side Scroll ButtonsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description WDFN-891 Investigate Side Scroll Buttons
-----------
I investigated multiple options for this task. In the end I settled on the simplest version. The main reason for this is that the scroll bar style is determined by the browser and the implementation is not standardized across browser. Firefox is in particular difficult to manage. So rather than attempt a hacky solution to override the various scrollbars, I opted to allow the browser to choose. The buttons are made universally reusable work in conjunction with a container that provides a put content and also includes a close 'button'. (see ticket for images)
After making a pull request
---------------------------
- [x] If appropriate, put the link to the PR in the JIRA ticket
- [x] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/716Revert "Merge branch 'wasp-421-data-integration' into 'main'"2023-01-27T22:04:28ZSimpson, Robert (Contractor) EvanRevert "Merge branch 'wasp-421-data-integration' into 'main'"Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [ ] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [ ] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
This merge has caused issues with the merge that I did from main into this branch. Will fix issue locally and open another merge request.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/712WASP-421: Introduce Vue Apollo GraphQL and Pinia Store2023-01-27T19:21:19ZSimpson, Robert (Contractor) EvanWASP-421: Introduce Vue Apollo GraphQL and Pinia StoreBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
- Introduces Vue Apollo to handle interacting with GraphQL server.
- Adds a Pinia store to handle state and actions associated with data fetching and retrieval from GraphQL.
There are various moving parts and decisions still being made to how the map operates with the amount of data being sent back. The map can get overwhelmed visually and slow down performance when there are lots of markers being added.
I had a code review session with Aaron to give a high level overview of what is going on and where we are at right now. There are stories coming up that will handle more of the interactions that will overtake the static display of the filters and way the map functions based on those filters being set.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/711wdfn-933 - Reworking iv data selectors2023-01-27T17:01:30ZWilliams, Darius Shamarwdfn-933 - Reworking iv data selectorsBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [x] Run all linters (make lint)
- [x] Run all tests (make test)
- [x] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Changed the label structure for selectors from iv-data.js to more closely reflect the types/subtypes of approval status
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.Williams, Darius ShamarWilliams, Darius Shamarhttps://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/710Added a test to TruncatedString to improve test coverage2023-01-25T22:47:46ZBucknell, Mary S.Added a test to TruncatedString to improve test coverageBefore making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Added a test for the click event as well as setting up the conditions to check truncation on a letter rather than punctation.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/708Wdfn 885 - Part 2, remove brush from hydrograph2023-01-25T22:19:01ZBucknell, Mary S.Wdfn 885 - Part 2, remove brush from hydrographBefore making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [ ] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [X] Run all linters (make lint)
- [X] Run all tests (make test)
- [X] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
The brush was removed from the hydrograph app portion of the UI. Zoom is enabled on all screen widths and a zoom hint appears when on desktop.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.https://code.usgs.gov/wma/iow/waterdataui/-/merge_requests/709switched to istanbul coverage to see if this fixes CI.2023-01-25T21:34:06ZBucknell, Mary S.switched to istanbul coverage to see if this fixes CI.Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [X] Run all...Before making a pull request
----------------------------
- [X] Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
- [ ] Run all linters (make lint)
- [X] Run all tests (make test)
- [ ] Update the changelog appropriately
- [ ] If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
-----------
Changing coverage providers to see if this fixes broken CI.
After making a pull request
---------------------------
- [ ] If appropriate, put the link to the PR in the JIRA ticket
- [ ] Assign someone to review unless the change is trivial
- [ ] Check the accessibility CI step and fix or explain any issues.