Revert "Add some error handling for get_instrument_calibrations"

This reverts commit b4ce9b7a.

geomagio/metadata/instrument/InstrumentCalibrations.py

@@ -327,34 +327,16 @@ def get_instrument_calibrations(
 
         # remove invalid metadata entries
         for i, m in enumerate(metadata):
-            if not m.data_valid or "instrument_category" not in m.metadata:
-                metadata.remove(m)
-
-        if not metadata or metadata is None:
-            raise ValueError(
-                f"No valid metadata returned for {observatory} for time interval: {start_time} - {end_time}"
-            )
-        else:
-            instrumentCalibrations = InstrumentCalibrations(metadata)
-            calibrations = instrumentCalibrations.get_calibrations()
-
-    if not calibrations or calibrations is None:
-        raise ValueError(
-            f"No valid calibrations returned for {observatory} for time interval: {start_time} - {end_time}"
-        )
-    else:
-        return [
-            c
-            for c in calibrations
-            if c["station"] == observatory
-            and (
-                end_time is None
-                or c["start_time"] is None
-                or c["start_time"] < end_time
-            )
-            and (
-                start_time is None
-                or c["end_time"] is None
-                or c["end_time"] > start_time
-            )
-        ]
+            if not m.data_valid:
+                metadata.pop(i)
+
+        instrumentCalibrations = InstrumentCalibrations(metadata)
+        calibrations = instrumentCalibrations.get_calibrations()
+
+    return [
+        c
+        for c in calibrations
+        if c["station"] == observatory
+        and (end_time is None or c["start_time"] is None or c["start_time"] < end_time)
+        and (start_time is None or c["end_time"] is None or c["end_time"] > start_time)
+    ]