Skip to content
Snippets Groups Projects

Add type hints to Timeseries Factory, add custom literal types

Suggestion for type hinting in Timeseries Factory.

Biggest change: Parameters interval and type are hinted with custom literals

Literals are specified in geomag_types.py:

DataInterval = Literal["tenhertz", "second", ...]

DataType = Literal["adjusted", ...]

My thinking is that the geomag_types module holds custom types we would like specified more than their underlying data type. @jmfee thoughts?

Edited by Cain, Payton David

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading