Attempt StringIO after failed BytesIO file read
Merged
requested to merge ghsc/users/erigler/geomag-algorithms:attempt-StringIO-after-BytesIO-with-input-URL into master
All threads resolved!
This is a bandaid to allow the --input-url
option to be used to
read in single files. It adds zero functionality beyond what already
existed when the --input-file
option was used.
Merge request reports
Activity
requested review from @jmfee
assigned to @erigler
- Resolved by Erin (Josh) Rigler
I'd still like to see a unit test that demonstrates the problem (in
test/Controller_test.py
) using one of the test data files.It seems that BytesIO has been working for url imports in the past. Instead of introducing StringIO, you could encode the value passed to BytesIO in the catch block:
BytesIO(data.encode('utf8'))
added 1 commit
- 03125a5c - Add test for --input-url to work with single file
- Resolved by Erin (Josh) Rigler
added 1 commit
- 0a33ca71 - Tweak .gitlab-ci.yml for new Gitlab requirment
mentioned in commit f0d522b7
Please register or sign in to reply