Skip to content
Snippets Groups Projects

Add spreadsheet factory functionality to copy_absolutes.py

Imported Enum to define a CLI parameter with a predefined set of values to choose from. Created a spreadsheets_dir option and factory option.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jeremy M Fee
  • Jeremy M Fee
  • added 2 commits

    • f2bd074f - Imported Enum to define a CLI parameter with a predefined set of values to...
    • 7b0c0378 - Fixing merge conflict

    Compare with previous version

  • added 8 commits

    • 7b0c0378...67eeb206 - 6 commits from branch ghsc/geomag:master
    • 53352c79 - Imported Enum to define a CLI parameter with a predefined set of values to...
    • a169c9bf - Working on Jeremy's comments

    Compare with previous version

  • added 1 commit

    • 3dc34aa1 - Changed dst_tot to compute the average ignoring nan values and added a new...

    Compare with previous version

  • Wernle, Alexandra Nicole requested review from @erigler and removed review request for @jmfee

    requested review from @erigler and removed review request for @jmfee

  • Jeremy M Fee resolved all threads

    resolved all threads

  • JMFee resolved threads from his earlier review, so I assume any/all of his technical comments were addressed.

    I like what I see, but I will ask for 2 minor things:

    1. add something that tells the user how many readings will be copied, then prompts for confirmation to upload or abort (typer has a basic "confirm" method); this is a very simple safety check until we get around to the TODO about checking for existing readings in the destination database.
    2. update your master branch then rebase this from that updated master; that should fix the issues with safety that are causing your pipeline to fail.
  • added 19 commits

    • a169c9bf...ecff6d45 - 16 commits from branch ghsc/geomag:master
    • 6ab4f988 - Imported Enum to define a CLI parameter with a predefined set of values to...
    • 14918e07 - Working on Jeremy's comments
    • d2b74f73 - Added confirm method as a check to user

    Compare with previous version

  • added 10 commits

    • d2b74f73...3a9f8ced - 6 commits from branch ghsc/geomag:master
    • 60cbdbfe - Imported Enum to define a CLI parameter with a predefined set of values to...
    • a60191e1 - Working on Jeremy's comments
    • 79319cf8 - Added confirm method as a check to user
    • 60c003b2 - Added force option to force skip the typer.confirm check

    Compare with previous version

  • Erin (Josh) Rigler resolved all threads

    resolved all threads

  • Erin (Josh) Rigler approved this merge request

    approved this merge request

  • Wernle, Alexandra Nicole marked this merge request as ready

    marked this merge request as ready

  • mentioned in commit dd8304c8

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading