Add spreadsheet factory functionality to copy_absolutes.py
Imported Enum to define a CLI parameter with a predefined set of values to choose from. Created a spreadsheets_dir option and factory option.
Merge request reports
Activity
requested review from @jmfee
assigned to @awernle
added 3 commits
-
db7e4d00...1b839cf0 - 2 commits from branch
ghsc/geomag:master
- cd3b06e4 - Merge branch 'master' into 'add_absolutes'
-
db7e4d00...1b839cf0 - 2 commits from branch
- Resolved by Jeremy M Fee
- Resolved by Jeremy M Fee
- Resolved by Jeremy M Fee
added 8 commits
-
7b0c0378...67eeb206 - 6 commits from branch
ghsc/geomag:master
- 53352c79 - Imported Enum to define a CLI parameter with a predefined set of values to...
- a169c9bf - Working on Jeremy's comments
-
7b0c0378...67eeb206 - 6 commits from branch
added 1 commit
- 3dc34aa1 - Changed dst_tot to compute the average ignoring nan values and added a new...
JMFee resolved threads from his earlier review, so I assume any/all of his technical comments were addressed.
I like what I see, but I will ask for 2 minor things:
- add something that tells the user how many readings will be copied, then prompts for confirmation to upload or abort (typer has a basic "confirm" method); this is a very simple safety check until we get around to the TODO about checking for existing readings in the destination database.
- update your master branch then rebase this from that updated master; that should fix the issues with safety that are causing your pipeline to fail.
added 19 commits
-
a169c9bf...ecff6d45 - 16 commits from branch
ghsc/geomag:master
- 6ab4f988 - Imported Enum to define a CLI parameter with a predefined set of values to...
- 14918e07 - Working on Jeremy's comments
- d2b74f73 - Added confirm method as a check to user
Toggle commit list-
a169c9bf...ecff6d45 - 16 commits from branch
- Resolved by Erin (Josh) Rigler
added 10 commits
-
d2b74f73...3a9f8ced - 6 commits from branch
ghsc/geomag:master
- 60cbdbfe - Imported Enum to define a CLI parameter with a predefined set of values to...
- a60191e1 - Working on Jeremy's comments
- 79319cf8 - Added confirm method as a check to user
- 60c003b2 - Added force option to force skip the typer.confirm check
Toggle commit list-
d2b74f73...3a9f8ced - 6 commits from branch
mentioned in commit dd8304c8
Please register or sign in to reply