Changes to AdjustedAlgorithm and AdjustedMatrix classes (and unit tests)
This MR includes a number of subtle changes to the Adjusted data-related classes that are intended to allow usera to treat non-F and F adjustments as separate algorithms. Arguably, this should have been done in the beginning, but I was not prepared to make such an impactful change to the package at this point in time.
Some details are provided in individual commit messages. I will also attempt to pre-review my own code and explain specific changes, since there are no reviewers on the team that are very familiar with the AdjustedAlgorithm any more.
Merge request reports
Activity
assigned to @erigler
- Resolved by Wilbur, Spencer Franklin
- Resolved by Erin (Josh) Rigler
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Erin (Josh) Rigler
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
- Resolved by Wilbur, Spencer Franklin
requested review from @swilbur
I addressed a couple comments. @swilbur, please resolve the remaining threads if you have no additional questions, and "approve" if you think this is ready to merge. I will merge once I get your approval. Thanks.
added 32 commits
-
edc40c29...e2c07570 - 28 commits from branch
ghsc/geomag:master
- 5ea8d330 - Changes to AdjustedMatrix class:
- 24fa5d71 - Changes to AdjustedAlgorithm class
- b038e693 - Changes to Adjustedalgorithm_test module
- 05a7bac6 - Remove left-over debugging print statement
Toggle commit list-
edc40c29...e2c07570 - 28 commits from branch
added 1 commit
- e2cb548a - Update dependency "cryptography" in pyproject.toml
This MR was reviewed nearly 3 months ago. It appears that after resolving all the comment threads, and marking the MR as "ready", it never actually got merged. I rebased, and updated the pyproject.toml file to address a minor vulnerability that popped up in the trivy scan while building the Docker image. The pipeline passed, so I will go ahead and merge.
mentioned in commit c7645ac8