Hotfix for Windows OS support
This MR provides a hotfix for #120 by making import fcntl
optional in Util.py
, so that code which relies on Util.py
can load successfully on Windows.
With this fix applied, if a Windows user tries to call util.write_state_file
or util.read_state_file
it will fail with a warning without blocking further execution. This should only affect Windows users that run MiniSeedFactory
with convert_channels ~= None
(unlikely!). Even if they do try this it should run successfully but without any reading or writing of state files.
I tested this fix on a Windows installation of Python and appears to work.
Merge request reports
Activity
requested review from @erigler
assigned to @bgeels
Sorry for the delay. I approve.
I'll also recommend that we look more into "integration tests" (thanks @ahobbs) based on FastAPI's TestClient. There are already some simple examples of this in our
test/
folder, and Ali is looking into expanding this considerably for the api code.added 7 commits
-
2ebe0145...ee077c7f - 4 commits from branch
ghsc/geomag:master
- 9cd8b708 - Make fcntl package optional in Util.py
- 9ff241d1 - Remove test code
- 7639ebf5 - Add tags to test job in gitlab-ci.yml
Toggle commit list-
2ebe0145...ee077c7f - 4 commits from branch
mentioned in commit 137410c0