Skip to content
Snippets Groups Projects

WIP: Add initial elements documentation

Closed Jeremy M Fee requested to merge ghsc/users/jmfee/geomag-algorithms:elements-docs into master
All threads resolved!

Attempt to capture what elements are acquired and derived, and information about how channels are derived.

@pcain, @erigler : let me know your thoughts on this, it's definitely incomplete. I'd like to finish some form of this documentation before reviewing the processing updates.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Erin (Josh) Rigler
  • Erin (Josh) Rigler
  • Erin (Josh) Rigler
  • I'm not sure why GitLab provides so much context for each of my comments. It seemed to me that it was only associating my comments with a single line of code. Let me know if you aren't certain which line of the MD file I was referring to with each comment.

    • Resolved by Jeremy M Fee

      @pcain , @erigler : note that when adding comments to issues you can select the drop down on the "Comment" button and change it to "Start thread" so we can have a threaded discussion that needs to be resolved. This is the default when commenting on code, but also useful for non-code discussions

    • Resolved by Cain, Payton David

      Something that arose when writing pipeline updates, which I am also seeing here, is the difference between base miniseed/edge channels as they are used to calculate derived channels. For instance:


      Adjusted Algorithm:

      Legacy: HEZF -> XYZF

      Miniseed: UVWF -> XYWF


      XYZAlgorithm:

      Legacy: XYZF -> D

      Miniseed: XYWF -> D


      XYZAlgorithm(adjusted data type):

      Legacy: XYZF -> H D

      Miniseed: XYWF -> U D


      If we want to process pure miniseed, then it would be a good idea to no longer describe outputs as the old SNCL channels. However, there's an opportunity to keep a channel like Z as it may be more descriptive than the raw variation channel. If we don't want to make this step right now, I can revert the changes to process using the edge factory/legacy sncls instead

  • Cain, Payton David mentioned in merge request !100 (closed)

    mentioned in merge request !100 (closed)

  • mentioned in issue #35 (closed)

  • Cain, Payton David mentioned in merge request !101 (merged)

    mentioned in merge request !101 (merged)

  • Cain, Payton David resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading