Skip to content

review

Belair, Gina Marie requested to merge gbelair/barry_arm_scenarios:gmb_review into main

Overall the code is very clear and concise. There were no major issues found with any of the review criteria, but it would be helpful to have more clarification comments as well as a few more instructions in key places. I completed the following steps:

  • Followed all installation instructions and added comments where issues were found
  • Ran 3 test simulations on my local machine to confirm each template worked (one mobility, one size, one failure extent for 3 methods: mixed, unmixed1, and unmixed2)
  • Reviewed analysis.R code for clarity, but was not able to be test this code since it requires the output of the 288 simulations

Merge request reports