Skip to content

Resolve "Setup scripts"

King, Jonathan M requested to merge ghsc/users/jking/pfdf:6-poetry-fixed into main

Closes #6 (closed)

This should address the items from the previous review. A few extra comments:

  1. The poetry error was related to how subprocess passes string arguments to the shell - this seems to behave slightly differently for windows vs linux. Anyways, it's fixed now...

  2. I've removed the tests for the stream module for the time being. This is because they break the pipeline (because they rely on ArcPy). They're defunct anyways, so I think this is alright for the time being - discussed further in #31 (closed)

  3. I've added black and isort formatting scripts to the dev workflow, but holding off on linting for the moment. I'll add this in soon (see #30 (closed)), but since there might be code changes I'll do it as a separate MR.

Merge request reports