Domain
Overview
This merge adds a few changes in response to the domain review. In summary, these are:
- Basins are now built from upstream to downstream
- Fixed data properties for exported basins
- Added conda installation
- Improved DEM conditioning
- watershed.network now returns pixel centers, rather than upper-right corners
Notes for Reviewer
I'd suggest focusing on the following points:
- The
environment.yml
file (this adds a conda install) -
pfdf/raster.py
- Renamed dx and dy to width and height (lines 225-237)
-
pfdf/segments.py
- Build outlet basins from upstream to downstream (lines 1167-1168)
- Enable data properties for basins (lines 2436-2440 and 2455-2459)
-
pfdf/watershed.py
- Improved DEM conditioning by using -Inf fill values instead of NaN (lines 130-137)
- Record pixel centers, rather than corners (lines 545-547 and 554-555)
Edited by King, Jonathan M