1.9.1 Administrative Security Review

This ticket documents the administrative security review of the nshmp-haz repository tagged branch 1.9.1.

A security review of the nshmp-haz branch 1.9.1 has been completed. Personal, private, otherwise sensitive information was not found in this repository. Please see minor comments below. This issue has been assigned to @pmpowers for reconciliation.

assigned to @khaynie

unassigned @khaynie

added In Progress label

code.json

• Version number is missing (current #.#.#). This is also missing in the downloadURL
• Include DOI when available

Updated in !561 (merged)

CONTRIBUTING.md

• Perhaps add a direct link to the "Fork a project" section (https://docs.gitlab.com/ee/user/project/working_with_projects.html#fork-a-project)

Keeping consistent with other repos for now but noting that this should be changed across the board in all our repos.

DISCLAIMER.md

• The software is not technically approved for release yet, may want to change the wording to "This software is preliminary or provisional and is subject to revision" until it is approved for release.

Updated in !561 (merged)

closed

assigned to @pmpowers

removed In Progress label

added In Progress label

reopened

changed the description

changed the description

changed title from Branch 1.9.1 Administrative Security Review to 1.9.1 Administrative Security Review

Items identified in this review have been addressed in !561 (merged). This issue will be closed upon approval for release.

changed milestone to %NSHM Hazard Tool launch

removed In Progress label

added Needs Review label

assigned to @khaynie and unassigned @pmpowers

Hi @pmpowers! Your changes look good. I have no further comments.

closed

removed Needs Review label