Beta implementation of PZCT18 complete. Models validated against Figures 3 and...

Beta implementation of PZCT18 complete. Models validated against Figures 3 and 4. Added log10 factor of 0.32 to coeff c1 as it appears to be omitted from Table 4 for PZCT18-2ES model and is needed to match response spectra

src/main/java/gov/usgs/earthquake/nshmp/gmm/Gmm.java

@@ -11,6 +11,7 @@ import java.util.Map;
 import java.util.Set;
 import java.util.function.Predicate;
 
+import com.google.common.annotations.Beta;
 import com.google.common.cache.CacheBuilder;
 import com.google.common.cache.CacheLoader;
 import com.google.common.cache.LoadingCache;
@@ -1102,6 +1103,7 @@ public enum Gmm {
       NgaEastUsgs_2017.CONSTRAINTS),
 
   /** @see PezeshkEtAl_2018 */
+  @Beta
   PZCT18_1SS(
       PezeshkEtAl_2018.PZCT18_1SS.class,
       PezeshkEtAl_2018.PZCT18_1SS.NAME,
@@ -1109,6 +1111,7 @@ public enum Gmm {
       PezeshkEtAl_2018.CONSTRAINTS),
 
   /** @see PezeshkEtAl_2018 */
+  @Beta
   PZCT18_2ES(
       PezeshkEtAl_2018.PZCT18_2ES.class,
       PezeshkEtAl_2018.PZCT18_2ES.NAME,

src/main/java/gov/usgs/earthquake/nshmp/gmm/PezeshkEtAl_2018.java

 /**
- * 
+ *
  */
 package gov.usgs.earthquake.nshmp.gmm;
 
@@ -15,6 +15,7 @@ import static java.lang.Math.sqrt;
 
 import java.util.Map;
 
+import com.google.common.annotations.Beta;
 import com.google.common.collect.Range;
 
 import gov.usgs.earthquake.nshmp.gmm.GmmInput.Constraints;
@@ -29,15 +30,19 @@ import gov.usgs.earthquake.nshmp.tree.LogicTree;
  * empirical-scaling approach (PZCT-2ES). The latter model is preferred by the
  * authors as the empirical-scaling approach reduces oversaturation of GMIM
  * predictions at large magnitudes, short distances, and short periods.
- * 
+ *
  * The prediction of GMIMs for site conditions other than Vs30 = 3000 m/s and k0
  * = 0.006s requires the use of appropriate site-amplification factors.
- * 
- * Questions:
- * 
+ *
+ * Note: it appears as if an "average empirical calibration factor of 0.32" (p.
+ * 2287, in log10 space) should be included in the value of coefficient c1 in
+ * Table 4 for the PZCT-2ES model but is not. This factor is added here in the
+ * Coefficients for the empirical-scaling model in order to match the response
+ * spectra in Figures 3 and 4.
+ *
  * - Table 4, should C10 at 3 sec be negative? There are other coefs that look
  * like they may have the wrong sign
- * 
+ *
  * <p><b>Note:</b> Direct instantiation of {@code GroundMotionModel}s is
  * prohibited. Use {@link Gmm#instance(Imt)} to retrieve an instance for a
  * desired {@link Imt}.
@@ -47,8 +52,8 @@ import gov.usgs.earthquake.nshmp.tree.LogicTree;
  * America using the hybrid empirical method and NGA-West2 Empirical
  * ground-motion models: Bulletin of the Seismological Society of America, v.
  * 108, n. 4, p. 2278-2304, August 2018.
- * 
- * 
+ *
+ *
  * <p><b>doi:</b> <a href="http://dx.doi.org/10.1785/0120170179">
  * 10.1785/0120170179</a>
  *
@@ -58,17 +63,9 @@ import gov.usgs.earthquake.nshmp.tree.LogicTree;
  * @see Gmm#PZCT18_1SS
  * @see Gmm#PZCT18_2ES
  */
+@Beta
 public abstract class PezeshkEtAl_2018 implements GroundMotionModel {
 
-  public static void main(String[] args) {
-    Coefficients c = new Coefficients(Imt.SA1P0, COEFFS_1SS, COEFFS_SIGMAS, Model.PZCT18_1SS);
-    System.out.println("hello");
-    System.out.println(c);
-    System.out.println(COEFFS_1SS.imts());
-    System.out.println(COEFFS_1SS.parseImt("0.04"));
-
-  }
-
   static final String NAME = "Pezeshk et al. (2018)";
 
   static final Constraints CONSTRAINTS = Constraints.builder()
@@ -83,9 +80,8 @@ public abstract class PezeshkEtAl_2018 implements GroundMotionModel {
   }
 
   /*
-   * Note: 0.04 seconds commented out because NGA-East SiteAmp doesn't support
-   * SA0P04 (also commented out there), similarly 0.08 seconds is commented out
-   * because SA0P08 is not supported by NGA-East SiteAmp.
+   * Note: 0.04 and 0.08 second coefficents are commented out because NGA-East
+   * SiteAmp doesn't support SA0P04 (also commented out there) or SA0P08.
    */
   static final CoefficientContainer COEFFS_1SS = new CoefficientContainer("PZCT18_1SS.csv");
   static final CoefficientContainer COEFFS_2ES = new CoefficientContainer("PZCT18_2ES.csv");
@@ -104,8 +100,15 @@ public abstract class PezeshkEtAl_2018 implements GroundMotionModel {
       Map<String, Double> coeffs = cc.get(imt);
       Map<String, Double> coeffs_sigma = cc_sigma.get(imt);
 
+      /*
+       * An "average empirical calibration factor" of 0.32 (log10-space)
+       * discussed on p. 2287 apparently did not make it into coefficient c1 in
+       * Table 5 (PZCT18_2ES), but is included in Table 4 (PZCT18_1SS).
+       */
+      double c1delta = (model == Model.PZCT18_2ES) ? -0.32 : 0.0;
+
       // median model coefficients
-      c1 = coeffs.get("c1");
+      c1 = coeffs.get("c1") + c1delta;
       c2 = coeffs.get("c2");
       c3 = coeffs.get("c3");
       c4 = coeffs.get("c4");
@@ -156,8 +159,7 @@ public abstract class PezeshkEtAl_2018 implements GroundMotionModel {
     double σ = calcStdDev(coeffs, in.Mw);
 
     SiteAmp.Value fSite = siteAmp.calc(μPga, in.vs30);
-    double μ2 = fSite.apply(μ);
-    assert μ2 == μ;
+    μ = fSite.apply(μ);
 
     return GroundMotions.createTree(μ, σ);
   }