Modifications to Site class

Now that site-data is included with a model, we don't need a service and including it necessitates a business logic hierarchy of what site data prevails when there are values in a sites.csv file, a site data service URL specified in a config, and/or a site-data directory present in a model. Furthermore, we don't want classes in lib dealing with URL calls; if site data is provided by a service, an external application should handle the calls and then populate a Site.Builder. Site class improvements:

• Make builder single-use
• Move SiteData and defaults from CalcConfig out of class, external classes to set values using builder
• Unit tests
• Sites to use DelimitedData
• Refactor Sites to return List<Site>

assigned to @pmpowers

changed title from Modifications to site data to Modifications to Site class

changed the description

changed the description

changed the description

marked the checklist item Make builder single-use as completed

marked the checklist item Make builder single-use as incomplete

marked the checklist item Make builder single-use as completed

marked the checklist item Move SiteData and defaults from CalcConfig out of class, external classes to set values using builder as completed

marked the checklist item Unit tests as completed

marked the checklist item Sites to use DelimitedData as completed

marked the checklist item Refactor Sites to return List<Site> as completed

Resolved in !208 (merged)

closed