Add Cybershake modifications to other NGA-West2 GMMs

Initial experimentation with BSSA_14_BASIN --> BSSA_14_CYBERSHAKE and subsequent analysis and discussion led to development of adjustments for the other three NGA-West2 GMMs.

• Replace BSSA_CYBERSHAKE implementation with BSSA_CYBERSHAKE_CENTERED and create BSSA_CYBERSHAKE_RS from *_CENTERED_RS implementation. Remove *_CENTERED models.
• Update tests with new IDs and check numbers haven't changed.
• Add flag handling to GMM unit tests.
• Add adjustment coefficients for CY_14_CYBERSHAKE, CB_14_CYBERSHAKE, and ASK_14_CYBERSHAKE.
• Add new *_CYBERSHAKE and *_CYBERSHAKE_ON implementations (*_ON replaces *_RS).
  • Coefficients added in !331 (merged)
• Add tests for *_CYBERSHAKE implementations.
• Incorporating SA and period dependence into cybershake flag (in constructors)

assigned to @kwithers

added 2023 GMM labels

changed milestone to %Beta release of CONUS NSHM

changed the description

changed the description

Notes from creation of initial tests that show changes for shallow z values where there shouldn't be:

• ASK14 order of operations; CSIM needs to be added before USGS basin depth tapering applied.
• CB14 something is funny

marked the checklist item Add adjustment coefficients for CY_14_CYBERSHAKE, CB_14_CYBERSHAKE, and ASK_14_CYBERSHAKE. as completed

marked the checklist item Add new *_CYBERSHAKE and *_CYBERSHAKE_ON implementations (*_ON replaces *_RS). as completed

marked the checklist item Add tests for *_CYBERSHAKE implementations. as completed

Updates in !333 (merged) !334 (merged) !335 (merged)

changed the description

Added additional task of incorporating SA and period dependence into cybershake flag

marked the checklist item Replace BSSA_CYBERSHAKE implementation with BSSA_CYBERSHAKE_CENTERED and create BSSA_CYBERSHAKE_RS from *_CENTERED_RS implementation. Remove *_CENTERED models. as completed

marked the checklist item Update tests with new IDs and check numbers haven't changed. as completed

marked the checklist item Incorporating SA and period dependence into cybershake flag (in constructors) as completed

SA and period dependence added to constructors in !336 (merged)

Flags can optionally be in last column of test input files in !337 (merged). Tests also updated.

marked the checklist item Add flag handling to GMM unit tests. as completed

Resolved in MRs mentioned in comments.

closed

reopened

There is some question about how to handle CY_CSIM within the CB model... it would be more self consistent with the other 3 GMMS to have a constant shift of 0.1 present at z2.5 = 1km (it is currently tapered in from 1-3 km from zero to full weight).

one method to do this would be to modify in CB GMM:

    double zScaled;
    if (cybershake) {       
    zScaled = zRefTerm * (1.0 - zScale) + z2p5Term * zScale +CY_CSIM;
    }else {
    zScaled = zRefTerm * (1.0 - zScale) + z2p5Term * zScale;
    }

and to remove CY_CSIM additions from calcBasinTerm

created branch 189-add-cybershake-modifications-to-other-nga-west2-gmms to address this issue

Resolved in !341 (merged)

closed

params_basinDepth_scaling_BSSA14_adjCS_KW.csv

update to BSSA CyberShake coefficients