Administrative Code Review
Completed on 2019-10-22
covering commits 9ba24469..c85859ed (subsequently 299c7b66) by @emartinez
-
Project is free of sensitive information -
Project is properly licensed -
Project is properly disclaimed -
Project includes proper metadata
Issues:
-
The
DESCRIPTION
file indicates the project is licensed under GPL-3 but the LICENSE.md file indicates CC0 1.0 and public domain. In either case, GPL-3 probably isn't allowable for a government project. Suggest changing the license field in DESCRIPTION file. -
Link in CODE_OF_CONDUCT.md is incorrect. Should be: https://www.usgs.gov/about/organization/science-support/science-quality-and-integrity/code-scientific-conduct
-
Links in CONTRIBUTING.md are incorrect. Should be:
-
Link in README.md is similarly incorrect. No need to re-include content in README.md that is already contained in other markdown files (e.g. CONTRIBUTING.md, etc...).
-
Various
.RData
files could not be reviewed as they were not text files. If these are data files (it seems like maybe they are), could they be moved to Git LFS? Or is there another, more appropriate location? -
Contained links to the project (Wiki?) sometimes use
http:
protocol rather thanhttps:
. The former is incorrect. Please update to usehttps:
.