Skip to content

templetizing rescaling work

White, Ellie requested to merge ew-passing-in-names into main

This may look like a big PR but it is the result of a lot fo work on a lot of different repos. I need reviewer to:

  1. make sure the code runs to completion and plots are made (i.e., all phases of the pipeline build)
  2. give feedback on whether things need to be put into functions rather than stay in the targets list (I struggle with where to draw the line)
  3. give feedback on instructions and comments. Do they make sense to someone with no familiarity with what we are trying to do.
  4. I am currently working on the README. If reviewer is inspired, I could use suggestions on how to improve that too. One section I will be adding is the list of all the people who have helped me develop this work to give credit.
  5. code review. Are there functions that are better to use than the ones I am using now. Are there erroneous functions or files that I don't need (I tried to catch them all and delete them). Are there best coding practices that I am not following (like documenting functions with roxygen2).

After this PR is merged. I will open a new issue to request the reviewer put in their own source, target, and AOI polygons and see where the pipeline breaks. We won't be making major modifications to accommodate all cases, but I think the pipeline needs assertions with assert_that() and stopifnot()s for the cases we are choosing not to handle.

Last step will be a security review.

Sorry to the reviewer to hand over what is essentially a big piece of work all in one go. There was no avoiding it because I intentionally wanted the reviewer to be somewhat unfamiliar with the weeds of this thing, but motivated enough to work through the snags with me.

Merge request reports