Skip to content

WDFN-671 - Align references to "classic" NWISWeb with WDFN Comms Campaign

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-671 into main

Before making a pull request

  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json, versionNumber and metadataLastUpdated.

Description

In addition to making the text changes requested in the ticket, I took the opportunity to clean up and enhance the implementations of the USWDS tooltips. There was unused and no longer needed code in the template to set the aria-describedby attribute that was there when we were implementing our own tooltips. Also in several case, I noticed that the better position of the tooltip, particularly on mobile was not the default "right". So I added the ability to set the position at tooltip creation time which will give us more flexibility.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial

Merge request reports