The source project of this merge request has been removed.
WDFN-697_Facebook shares - use intent tweet
Before making a pull request
-
Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/) -
Run all linters (make lint) -
Run all tests (make test) -
Update the changelog appropriately -
If making a release, update code.json, versionNumber and metadataLastUpdated.
Description WDFN-697_Facebook shares - use intent tweet
After testing, I found that the 1000px wide image worked better with Facebook and the 500px with Twitter. I also adjusted the share link to use the 'intent' option so that the basic tweet is created rather than going to the Twitter home page.
After making a pull request
-
If appropriate, put the link to the PR in the JIRA ticket -
Assign someone to review unless the change is trivial