Skip to content

Wdfn 740 - Replace components/hydrograph/parameters.js with a Vue component

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-740 into main

Before making a pull request

Description

Replaced parameters.js in monitoring-location/components with a Vue component, parameter-selection.vue. Also replaced method-picker.js with a Vue component method-picker.vue. I was able to simplify the markup used to render each parameter code row by using the css style attribute "order" to control the order that components where rendered determined by media queries.

This also covers WDFN-741.

There are additional tickets that might come out of this, including making a separate Vue component for the info tooltip. At some point we should also investigate putting component specific style in the components. I may still do this as part of this ticket but for now I am satisified that this meets the acceptance criteria.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial

Merge request reports

Loading