Skip to content

WDFN-733 Plot 2nd Time Series - implement UI

Before making a pull request

Description WDFN-733 Plot 2nd Time Series - implement UI

Includes changes to the user interface such that the user can select from a list of secondary parameters. Changes include this that were listed in the acceptance criteria

  • Checkbox added to each expandable section of the parameter selection table
  • Un-clicking the checkbox will re-enable the compare and median checkboxes and remove the secondary parameter from the graph title.
  • The initial implementation will show only the parameter name for the label for each secondary time series option
  • Selecting a new row in the parameter table will retain the secondary time series and draw it on the graph with the newly selected series. If the new series is the same as the secondary series, it will uncheck the option to plot a secondary time series

These change where also listed in the acceptance criteria but could not be done in this ticket as the data required must first be fetched from the data source which is part of ticket https://internal.cida.usgs.gov/jira/browse/WDFN-735

  • Clicking the check box will show the secondary parameter in the graph title below the primary parameter and disable the compare and median checkboxes.
  • Only the ‘sampling method/sublocation’ normally graphed will be listed as an option
  • If there are multiple sampling methods the method name should be added in brackets ‘[ ]’
  • Changing the secondary parameter that is selected updates the title in the hydrograph.

Additionally, the test coverage for parameter-selection.vue is only 86% which was because some things were hard to test, but also some things are in progress and don't yet have an action attached to the change whose result can be tested.

One more thing, in the end I retained the current ability that allows the user to expand a non-selected parameter row. Because of this the user can select a second parameter to graph from any row. From a logic perspective this seems consistent with how the second parameter selection should work, which is that it is independent from the primary parameter selection. However, I have mixed feelings about this from the perspective of user experience and user expectation.

Image - Primary parameter, Gage height, selected and secondary parameter selected from the expanded but non-selected row of Discharge. image

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
Edited by Briggs, Aaron Shane

Merge request reports

Loading