Skip to content

Use Vue to render the hydrograph graph-brush

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-759 into main

Before making a pull request

Description

Using Vue to render the graph-brush component in the hydrograph. The code uses watchEffect rather than using the "link" command that we are using to tie changes in the Redux store to implement rendering code that is more complex than just updating an attribute. The code also uses computed values to determine the value of attributes such as viewBox and transform in the svgs.

The D3 rendering code that draws and manages the brush was pretty much copied from monitoring-location/component/hydgrograph/graph-brush.js. The changes really related to creating markup and rendering the component when the appropriate data in Redux is updated.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial

Merge request reports

Loading