Skip to content

WDFN-790: Fixed bug with second parameter selection and sites with no IV data.

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-790 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Fixed bug with the code that determined if the secondary parameter selection should be enabled. Fixed the code and simplified the logic within the function. In addition I added a test for the bug condition and modified the tests to look for the existance of the SecondaryParameterControls component rather than an implementation dependent class that is not actually part of our code base.

I added a new section to our fake index page that has several sites at the top with various characteristics. This will be useful for testing new feature work.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial

Merge request reports