Skip to content

Draft: WDFN-683 v2 - Investigate Hydrograph Zooming Options

Briggs, Aaron Shane requested to merge (removed):WDFN-683_V2 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description Draft: WDFN-683 v2 - Investigate Hydrograph Zooming Options

This is part of an investigation task and can be viewed as an example

This is a working example (is just missing unit tests)

Features -

  • zooming of the hydrograph on mobile (was able to test on mobile, but the documentation for D3 Zoom indicates that touch is enabled by default. For more detail see https://github.com/d3/d3-zoom#zoom_touchable
  • uses the brush for zoom on desktop

Please see the Jira ticket, https://internal.cida.usgs.gov/jira/browse/WDFN-683, for full details

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial

Merge request reports