Wdfn 768 - Convert the legend component to vue
All threads resolved!
All threads resolved!
Before making a pull request
-
Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/) -
Run all linters (make lint) -
Run all tests (make test) -
Update the changelog appropriately -
If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
Added a vue component for the hydrograph legend. Added the graph controls component to the hydrograph app.
After making a pull request
-
If appropriate, put the link to the PR in the JIRA ticket -
Assign someone to review unless the change is trivial
Edited by Williams, Darius Shamar
Merge request reports
Activity
requested review from @mbucknell
assigned to @dswilliams
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
- Resolved by Williams, Darius Shamar
Before we use this in the dv hydrograph, we will want to put it the legend in a directory outside the specific monitoring location components. Right now we have a scripts/uswds-components directory which I will likely change to vue-components since the uswds-components will be moving to wdfn-vue-component library and I already have a component for as part of my work on the time-series-graph ticket. So it's fine to leave where it is but it will be moving.
So this is good to go now.
mentioned in commit 4b22bb12
Please register or sign in to reply