Skip to content
Snippets Groups Projects

Wdfn 768 - Convert the legend component to vue

Merged Williams, Darius Shamar requested to merge dswilliams/waterdataui:wdfn-768 into main
All threads resolved!

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR title (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Added a vue component for the hydrograph legend. Added the graph controls component to the hydrograph app.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
Edited by Williams, Darius Shamar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Williams, Darius Shamar changed the description

    changed the description

  • added 1 commit

    • f9d53f72 - Adding a prop for the daily value legend

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Bucknell, Mary S.
  • See comments. Let's also change the module name of legend.vue to hydrograph-legend.vue.

  • added 1 commit

    • c3ae507e - Cleaning up code, adding comments

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Before we use this in the dv hydrograph, we will want to put it the legend in a directory outside the specific monitoring location components. Right now we have a scripts/uswds-components directory which I will likely change to vue-components since the uswds-components will be moving to wdfn-vue-component library and I already have a component for as part of my work on the time-series-graph ticket. So it's fine to leave where it is but it will be moving.

    So this is good to go now.

  • Bucknell, Mary S. approved this merge request

    approved this merge request

  • Williams, Darius Shamar resolved all threads

    resolved all threads

  • mentioned in commit 4b22bb12

  • Please register or sign in to reply
    Loading