Skip to content

WDFN-775: Convert the daily-value-hydrograph/time-series-graph to a Vue component

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-775 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

In order to do this, I developed a reusable TimeSeriesGraph component along with some supporting components to implement the time series graph tooltip. By doing this, we can reuse a lot of code between the IV and DV stats graph while maintaining consistency in look and feel and implementation while customizing the tooltip contents and graph information.

The new components utilize slots for custom content such as what should be drawn within the time series graph and emits events for the cursor offset that are then handled for a specific implementation.

I believe similar techniques can be used for the graph brush and cursor slider so that those implementation are reusable. I will be creating tickets for this work.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports