Skip to content

Wdfn 776 - Clean up component/daily-value-hydrograph to have a single App instance

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-776 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

All Vue apps for the daily value hydrograph component have been consolidated into a single app, DvHydrographApp. Added in the loading indicator component and the info alert so those no longer need to be in the component template. Removed all files that are no longer needed.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports