Skip to content

WARP-809: Made a separate GraphBrush component.

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-809 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

There is now a component, GraphBrush, that can be used to implement a graph brush and is now used for both the IV and DV graph.

I also fixed a bug with needing to reset the graphBrushOffset when changing from an IV to a GW-only parameter (and vice versa). There was additional cleanup that I also noticed for tests, etc.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports