Skip to content

WDFN-788 (Add on) Fix Issue Where Button Payload was Object

Briggs, Aaron Shane requested to merge (removed):WDFN-788_create_uswdsradiobutton_and_button_set into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description WDFN-788 (Add on) Fix Issue Where Button Payload was Object

While converting the radio buttons to wdfn-vue-components, I experimented with having the button return and object thinking that this would be more generic and versatile, like a REST app, but after investigation, I found that the value of a radio button should always be a string. Knowing this, I reverted from objects to strings as the value of the buttons, but I missed this one place.

So long story short, fixed the return value of button and converted secondary parameter controls to use the setup tag.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports