Skip to content

WDFN-551: Fixed circular dependency issue in list.js

Bucknell, Mary S. requested to merge mbucknell/waterdataui:fix_rollup into main

Before making a pull request

  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately - Change to dependencies. No changelog update is needed

Description

Was able to fix the problem by pulling in the list.js dependency from the node_modules/src directory and pulled in the pagination dependency that was the problem before list.js itself. I also used the pagination options to adjust the pagination markup to have assign the href appropriately so that the scrolling to the top issue does not occur.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial

Merge request reports