Skip to content

Add discrete data summary table

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-832 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Added a new Vue app component to hold the discrete samples summary table. The initial implementation uses a USWDSAccordion component that is initially closed. Upon opening, the summary data is fetched, and the table populated. During fetching a "data loading" message will appear. If the fetch fails, no table will be rendered. An error message will be shown indicating that there was a data service error.

The summary table is implemented with a paginated table component. The PaginatedTable component has been moved to the vue-components directory at the top level so that it can be used anywhere and has been reworked to use the sort_arrow to show columns that are sortable but not yet sorted. Also modified the component to consolidate into a single array property the information that defines columns. For each column there is a property for heading, dataKey, and whether the column can be sorted with an optional property to allow the initial sorting direction to be specified by the user of the module.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports