Skip to content

Wdfn 830 - Build style sheets for pages that use javascript with vite

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-830 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Style sheets for the three pages that have separate javascript bundles (monitoring-location, multi-site-hydrograph, and networks) now have their style sheets built using vite. This allows faster building and allows Vue SFC to include the style sheet, thereby more closely linking a components style and markup. Please note that I did not change Vue component organization. We may want to consider doing this so that the style for the hydrograph elements which are needed to draw both the graph and the legend are more isolated. But for now this works and should mean less confusion about where to look for a particular style. This also prevents style that is used on more than one page for thing like the TextLoadingIndicator to appear in only one place. As part of this work, I removed some style declarations that were no longer being used.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Edited by Bucknell, Mary S.

Merge request reports