Skip to content

Initial implementation of a Vue component for the IvHydrgraphLegend that uses reusable Vue components for the markers

Bucknell, Mary S. requested to merge mbucknell/waterdataui:spike_legend into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump to next version.


The IV Hydrograph Legend is now rendered without using D3 but rather a Vue component that uses reusable Vue components to render the markers. This implementation is a more straightforward and easier to maintain implementation of the legend and lends itself to reuse of the marker components in a variety of places, such as the future Data Details section.

Currently, I have only reimplemented the IV Hydrograph Legend. A subsequent MR will reimplement the DV Hydrograph Legend and remove the GraphLegend and d3 markers modules as they will no longer be used at that time.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports