Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W waterdataui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Water Mission Area
  • Internet of Water
  • waterdataui
  • Merge requests
  • !630

WDFN-887 Make Data Details View container with feature toggle

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-887_make_data_details_vue_container into main Dec 08, 2022
  • Overview 2
  • Commits 4
  • Pipelines 2
  • Changes 7

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-887 Make Data Details View container with feature toggle

Adds a container with placeholder elements for the Data Details and Statistics tables.

I didn't update the changelog, since I wasn't sure if we updated the changelog for features that are toggled off and since it is basically an empty container, it is not really worth mentioning.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: WDFN-887_make_data_details_vue_container