Skip to content

wdfn-892 - Changing video scaling from height to width

Williams, Darius Shamar requested to merge dswilliams/waterdataui:wdfn-892 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

This issue was a combination of the service that supplies the videos not being consistent in their usage of "720" in denoting resolutions, and that our existing styling for shrinking the videos was not actually doing anything (it just looked good because the videos where already small from the service). More specifically, the apps.usgs.gov video host gives videos in 720x407, which is not standard for a 720p video, and denotes all the "working" sites in the ticket. The other host, usgs-nims-images.s3.amazonaws.com, gives videos in 1280x720, or actual 720p, and thus appears overlong when the previous styling didn't stymie the width.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports