Skip to content

WDFN-879 Create Data Details Component

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description WDFN-879 Create Data Details Component

This code adds the 'selected' point rows to the new data details 'table'. After discussing with Mary, it was decided that we wanted to break this already large merge request down by removing the code for the 'most recent value' as described in the ticket. That code requires additional logic and changes that we would like to discuss as team and so the initial example of that was removed from this merge request.

This code covers (these and many other fringe cases) The primary selected value

Image - The primary selected value

image

Primary and secondary selected parameter values and masks

Image - primary and secondary selected with data mask

image

Data types with no data

Image - primary and secondary selected each with no data

image

Has a place holder for field visits as this will need additional logic which was outside of the ticket scope

Image - temporary field visits placeholder

image

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Edited by Briggs, Aaron Shane

Merge request reports

Loading