Skip to content

Wdfn 709 - Handle slow service calls

Williams, Darius Shamar requested to merge dswilliams/waterdataui:wdfn-709 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Added try/except for all service calls to catch timeout errors. Added a 10s timeout to all service calls not within nwissite.py. Increased the mccabe complexity limit for linting by two because ignoring the warning didn't seem to be working.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports