Skip to content

WDFN-905 - Change the loading indicator to use v-show rather than v-if

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-905 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Using v-show rather than v-if for the loading indicator. This allows the WDFN graph server to use the loading indicator's visibility within the hydrograph wrapper to determine when data loading is complete and when it can take the snapshot of the graph.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Edited by Bucknell, Mary S.

Merge request reports