Skip to content

Draft: Wdfn 915

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-915 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

I added a Pinia store to contain the metadata for all available IV data including the latest value. This is the equivalent to hydrographParameters in the Redux store. The service call is made within HydrographApp so at the moment the service call is made twice, once to populated hydrographParameters and once to populate the available-iv-data-store. Of note in available-iv-data-store, one of the getters returns a function which can be used to retrieve the data for a specific parameterCode/methodId.

I created a DataDetailsLatestValueRow component to render the latest value row in the data details section. The constants to define the labels and classes to use for the masked qualifiers, the approval qualifiers, and the HASH_ID I put into monitoring-location/components/hydrograph/iv-data-qualifiers.js (I need a better name). There are some functions to extract the appropriate data from a qualifier array. This is used in DataDetailsLatestValueRow.

The HydrographApp.test.js tests are not passing. I am not sure why but didn't want to chase it down.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports