Skip to content

WDFN-880 Add Reformatted Statistics Table (addon)

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-880_add_reformatted_statistics_table into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-880 Add Reformatted Statistics Table (addon)

This removes the media query used for the data details and new statistics table from the selector in Layout.js.

It adds the npm Vue utility package 'useVue' and utilized the 'useMediaQuery' from that package.

The 'useMediaQuery' is superior to the 'mediaQuery' we currently use as it is reactive in Vue components out-of-the-box and should eventually be used to replace all usage of the existing 'mediaQuery' utility function.

I am seeing a warning when running the tests for hydrographApp, but I removed my new code and the warning persisted, so I'm confident that it is not related to this change. However it does appear to related to the onMounted lifecycle hook in hydrographApp and the new(er) additions to the Data Details table. The warning: onMounted is called when there is no active component instance to be associated with. Lifecycle injection APIs can only be used during execution of setup(). If you are using async setup(), make sure to register lifecycle hooks before the first await statement

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports